adamsaghy commented on code in PR #4904:
URL: https://github.com/apache/fineract/pull/4904#discussion_r2303365126
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccrualWritePlatformServiceImpl.java:
##########
@@ -158,13 +158,19 @@ private void addAccrualTransactions(SavingsAccount
savingsAccount, final LocalDa
final List<LocalDate> accrualTransactionDates =
savingsAccount.retrieveOrderedAccrualTransactions().stream()
.map(transaction -> transaction.getTransactionDate()).toList();
+ final List<LocalDate> accrualTransactionDatesReverse =
savingsAccount.retrieveOrderedAccrualTransactions().stream()
Review Comment:
Could you please rename this field? At first glance it seems to be a list of
accrual transactions in reverse date order, but in fact it’s a list of reversed
accrual transactions. The name should make that explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
