adamsaghy commented on code in PR #5078:
URL: https://github.com/apache/fineract/pull/5078#discussion_r2489150775
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanTransactionProcessingServiceImpl.java:
##########
@@ -149,13 +149,17 @@ private Loan getLoan(List<LoanTransaction>
loanTransactions, List<LoanRepaymentS
@Override
public ChangedTransactionDetail reprocessLoanTransactions(String
transactionProcessingStrategyCode, LocalDate disbursementDate,
List<LoanTransaction> loanTransactions, MonetaryCurrency currency,
List<LoanRepaymentScheduleInstallment> installments,
- Set<LoanCharge> charges) {
+ Set<LoanCharge> charges, boolean
interestRecognitionOnDisbursementDate) {
final LoanRepaymentScheduleTransactionProcessor
loanRepaymentScheduleTransactionProcessor = getTransactionProcessor(
transactionProcessingStrategyCode);
if (loanRepaymentScheduleTransactionProcessor instanceof
AdvancedPaymentScheduleTransactionProcessor advancedProcessor) {
- LocalDate currentDate = DateUtils.getBusinessLocalDate();
+ LocalDate interestForDate = DateUtils.getBusinessLocalDate();
+ if (interestRecognitionOnDisbursementDate &&
interestForDate.equals(disbursementDate)) {
Review Comment:
I dont think its correct to use current date + 1 which effectively a future
date. We cannot work against future date for transaction processing. Also
interest is payable on the current date anyway, we dont need this.
`interestRecognitionOnDisbursementDate` is ONLY for accruals, nothing else!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
