alberto-art3ch commented on code in PR #5078:
URL: https://github.com/apache/fineract/pull/5078#discussion_r2503580432
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java:
##########
@@ -1216,8 +1216,7 @@ private BigDecimal setScaleAndDefaultToNullIfZero(final
BigDecimal value) {
return value.setScale(6, MoneyHelper.getRoundingMode());
}
- public boolean isFirstNormalInstallment() {
- return loan.getRepaymentScheduleInstallments().stream().filter(rp ->
!rp.isDownPayment()).findFirst().stream()
- .anyMatch(rp -> rp.equals(this));
+ public boolean
isFirstNormalInstallment(List<LoanRepaymentScheduleInstallment> installments) {
Review Comment:
It is required to find the first normal installment because we are talking
about the contract termination in the disbursement date and we were not able to
identify the first normal installment @adamsaghy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
