adamsaghy commented on code in PR #5167:
URL: https://github.com/apache/fineract/pull/5167#discussion_r2565346916


##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java:
##########
@@ -964,7 +994,7 @@ BigDecimal calculateRateFactorPerPeriodForInterest(final 
ProgressiveLoanInterest
         final BigDecimal actualDaysInPeriod = BigDecimal
                 .valueOf(DateUtils.getDifferenceInDays(interestPeriodFromDate, 
interestPeriodDueDate));
         final BigDecimal calculatedDaysInPeriod = BigDecimal
-                
.valueOf(DateUtils.getDifferenceInDays(repaymentPeriod.getFromDate(), 
repaymentPeriod.getDueDate()));
+                
.valueOf(DateUtils.getDifferenceInDays(repaymentPeriod.getFromDate(), 
repaymentPeriod.getOriginalDueDate()));

Review Comment:
   This looks incorrect. We need to calculate the interest for all the days 
inside the period.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to