tweise commented on a change in pull request #21:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/21#discussion_r814394166
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##########
@@ -109,6 +118,19 @@ public DeleteControl cleanup(FlinkDeployment flinkApp,
Context context) {
} catch (Exception e) {
throw new ReconciliationException(e);
}
+
+ if
(!jobManagerDeployments.contains(flinkApp.getMetadata().getSelfLink())) {
+ Optional<Deployment> deployment =
context.getSecondaryResource(Deployment.class);
+ if (deployment.isPresent()) {
+ LOG.info(
+ "JobManager deployment {} in namespace {} is ready",
+ flinkApp.getMetadata().getName(),
+ flinkApp.getMetadata().getNamespace());
+
jobManagerDeployments.add(flinkApp.getMetadata().getSelfLink());
+ // reschedule for immediate job status check
+ return UpdateControl.updateStatus(flinkApp).rescheduleAfter(0);
Review comment:
The annotation does not seem to change anything wrt the original error.
There is a separate reschedule interval for this condition, which absent of
more sophisticated readiness check I have set to 5s for now - that seems to
avoids the timeout exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
