tweise commented on a change in pull request #21:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/21#discussion_r815363350
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##########
@@ -114,6 +126,39 @@ public DeleteControl cleanup(FlinkDeployment flinkApp,
Context context) {
} catch (Exception e) {
throw new ReconciliationException(e);
}
+
+ return checkDeployment(flinkApp, context);
+ }
+
+ private UpdateControl<FlinkDeployment> checkDeployment(
+ FlinkDeployment flinkApp, Context context) {
+ if
(!jobManagerDeployments.contains(flinkApp.getMetadata().getSelfLink())) {
Review comment:
It is a unique reference that avoids caching entire resource objects and
duplicate key construction. Why should the field not exist? Did you encounter
it somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
