tweise commented on a change in pull request #62:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/62#discussion_r827630817
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -129,6 +129,16 @@ public boolean isJobManagerPortReady(Configuration config)
{
return false;
}
+ public boolean isJobManagerServing(Configuration config) {
+ try (ClusterClient<String> clusterClient = getClusterClient(config)) {
+ clusterClient.listJobs().get(10, TimeUnit.SECONDS);
+ return true;
Review comment:
Please move the timeout into the config, the previous delay was also
configurable. Did you check how the timeout behaves? If REST API is not
available when the call is made and then becomes available after 5s, will the
list call still fail after waiting for 10s? I believe that's what I had seen
when testing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
