[GitHub] [flink-kubernetes-operator] bgeng777 commented on a change in pull request #62: [FLINK-26605] Check if JM can serve rest api calls every time before reconcile

[GitBox]

bgeng777 commented on a change in pull request #62:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/62#discussion_r828999559



##########
File path: 
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/BaseObserver.java
##########
@@ -62,8 +62,22 @@ protected void observeJmDeployment(
         JobManagerDeploymentStatus previousJmStatus =
                 deploymentStatus.getJobManagerDeploymentStatus();
 
+        if (JobManagerDeploymentStatus.READY == previousJmStatus) {
+            if (!flinkService.isJobManagerServing(effectiveConfig)) {
+                deploymentStatus.setJobManagerDeploymentStatus(
+                        JobManagerDeploymentStatus.DEPLOYED_NOT_READY);
+                logger.warn("The job manager is currently not ready for 
serving.");
+            }
+            return;
+        }

Review comment:
       Thanks for pointing this out. I remove the `observeJmDeployment` call in 
`observeFlinkJobStatus`. Let me know if that is our expected change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org