urlyy commented on code in PR #2492:
URL: https://github.com/apache/fory/pull/2492#discussion_r2297564695
##########
rust/fory-core/src/types.rs:
##########
@@ -87,19 +110,19 @@ pub fn compute_string_hash(s: &str) -> u32 {
hash as u32
}
-const BASIC_TYPES: [FieldType; 11] = [
- FieldType::BOOL,
- FieldType::INT8,
- FieldType::INT16,
- FieldType::INT32,
- FieldType::INT64,
- FieldType::FLOAT,
- FieldType::DOUBLE,
- FieldType::STRING,
- FieldType::BINARY,
- FieldType::DATE,
- FieldType::TIMESTAMP,
-];
+// const BASIC_TYPES: [FieldType; 11] = [
Review Comment:
> why those lines are commented? Could you chekc all code in this PR to
avoid commented code by mistake?
These code seems useless so I comment them temporarily.
##########
rust/fory-core/src/types.rs:
##########
@@ -87,19 +110,19 @@ pub fn compute_string_hash(s: &str) -> u32 {
hash as u32
}
-const BASIC_TYPES: [FieldType; 11] = [
- FieldType::BOOL,
- FieldType::INT8,
- FieldType::INT16,
- FieldType::INT32,
- FieldType::INT64,
- FieldType::FLOAT,
- FieldType::DOUBLE,
- FieldType::STRING,
- FieldType::BINARY,
- FieldType::DATE,
- FieldType::TIMESTAMP,
-];
+// const BASIC_TYPES: [FieldType; 11] = [
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
