urlyy commented on code in PR #2492:
URL: https://github.com/apache/fory/pull/2492#discussion_r2297969751
##########
rust/fory-core/src/meta/type_meta.rs:
##########
@@ -18,19 +18,102 @@
use super::meta_string::MetaStringEncoder;
use crate::buffer::{Reader, Writer};
use crate::error::Error;
+use crate::meta::murmurhash3_x64_128;
use crate::meta::{Encoding, MetaStringDecoder};
+use crate::types::FieldType;
use anyhow::anyhow;
+use std::cmp::min;
+#[derive(Debug, PartialEq, Eq)]
+pub struct FieldTypeResolver {
Review Comment:
I think so. But there already has enum named `FieldType` at
`fory-core/types.rs`.
##########
rust/fory-core/src/meta/type_meta.rs:
##########
@@ -18,19 +18,102 @@
use super::meta_string::MetaStringEncoder;
use crate::buffer::{Reader, Writer};
use crate::error::Error;
+use crate::meta::murmurhash3_x64_128;
use crate::meta::{Encoding, MetaStringDecoder};
+use crate::types::FieldType;
use anyhow::anyhow;
+use std::cmp::min;
+#[derive(Debug, PartialEq, Eq)]
+pub struct FieldTypeResolver {
Review Comment:
I think so. But there already has enum named `FieldType` at
`fory-core/types.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
