chaokunyang commented on code in PR #1424:
URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537038165
##########
java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java:
##########
@@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serializer
serializer) {
register(type);
}
- /** Register common class ahead to get smaller class id for serialization. */
- private void registerCommonUsedClasses() {
Review Comment:
Those classes shouldn't be removed, otherwise they will be allocated a
bigger ID in `addDefaultSerializers`, which will be serialized using 2 bytes.
The principle is to ensure frequently used classes get a smaller ID to make
them be serialized in a byte, which is the range: `0~63`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
