chaokunyang commented on code in PR #1424:
URL: https://github.com/apache/incubator-fury/pull/1424#discussion_r1537120046
##########
java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java:
##########
@@ -356,20 +352,12 @@ private void addDefaultSerializer(Class type, Serializer
serializer) {
register(type);
}
- /** Register common class ahead to get smaller class id for serialization. */
- private void registerCommonUsedClasses() {
Review Comment:
Another issue to note is that there are some classes registered in
`ClassResolver#addDefaultSerializers` which may be more frequent than classes
in `registerDefaultClasses`:
```java
register(Boolean[].class, Byte[].class, Short[].class,
Character[].class);
register(Integer[].class, Float[].class, Long[].class, Double[].class);
register(AtomicBoolean.class);
register(AtomicInteger.class);
register(AtomicLong.class);
register(AtomicReference.class);
```
Could we register such frequent classes in `registerDefaultClasses` ahead to
avoid the less frequent classes such as `AtomicReference` to use an id in range
`0~63`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
