chaokunyang commented on code in PR #1467: URL: https://github.com/apache/incubator-fury/pull/1467#discussion_r1552603974
########## java/fury-core/src/main/java/org/apache/fury/BaseFury.java: ########## @@ -64,9 +71,16 @@ public interface BaseFury { */ <T> void registerSerializer(Class<T> type, Class<? extends Serializer> serializerClass); + void registerSerializer(Class<?> type, Serializer<?> serializer); Review Comment: The serializer is bind to a Fury instance, we may not be able to create a serializer object for registration unless we change the serializer interfere. Could we change this to register(Class type, Class serializer class)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org For additional commands, e-mail: commits-h...@fury.apache.org