Munoon commented on code in PR #1467:
URL: https://github.com/apache/incubator-fury/pull/1467#discussion_r1553192936
##########
java/fury-core/src/main/java/org/apache/fury/BaseFury.java:
##########
@@ -64,9 +71,16 @@ public interface BaseFury {
*/
<T> void registerSerializer(Class<T> type, Class<? extends Serializer>
serializerClass);
+ void registerSerializer(Class<?> type, Serializer<?> serializer);
Review Comment:
There might be a singleton serializer. I've personally create some of them
in my project. In this case they will be applied to each existing and each new
Fury instances in `ThreadLocalFury` and `ThreadPoolFury`.
Maybe this is something that worth mentioning in the documentation.
However, if you didn't like it, we can remove this method and make user
register singleton serializers using `execute` method. In this case, there is
more chances that user will know what he is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@fury.apache.org
For additional commands, e-mail: commits-h...@fury.apache.org
