rui-mo commented on code in PR #4829:
URL: https://github.com/apache/incubator-gluten/pull/4829#discussion_r1531725452
##########
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala:
##########
@@ -318,8 +318,9 @@ object BackendSettings extends BackendSettingsApi {
case _ =>
}
windowExpression.windowFunction match {
- case _: RowNumber | _: AggregateExpression | _: Rank | _: CumeDist
| _: DenseRank |
- _: PercentRank | _: NthValue | _: NTile | _: Lag | _: Lead =>
+ case _: RowNumber | _: Rank | _: CumeDist | _: DenseRank | _:
PercentRank |
+ _: NthValue | _: NTile | _: Lag | _: Lead =>
+ case aggrExpr: AggregateExpression if
!aggrExpr.isInstanceOf[ApproximatePercentile] =>
Review Comment:
I think we need the match against the aggregate function like below, thanks.
> case aggExpresion: AggregateExpression if
aggExpresion.aggregateFunction.isInstanceOf[ApproximatePercentile] => false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
