zhztheplayer commented on code in PR #4829:
URL: https://github.com/apache/incubator-gluten/pull/4829#discussion_r1538529337
##########
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala:
##########
@@ -323,8 +323,10 @@ object BackendSettings extends BackendSettingsApi {
case _ =>
}
windowExpression.windowFunction match {
- case _: RowNumber | _: AggregateExpression | _: Rank | _: CumeDist
| _: DenseRank |
- _: PercentRank | _: NthValue | _: NTile | _: Lag | _: Lead =>
+ case _: RowNumber | _: Rank | _: CumeDist | _: DenseRank | _:
PercentRank |
+ _: NthValue | _: NTile | _: Lag | _: Lead =>
+ case aggrExpr: AggregateExpression
+ if
!aggrExpr.aggregateFunction.isInstanceOf[ApproximatePercentile] =>
Review Comment:
So this is because Velox doesn't yet support approximate percentile. Perhaps
after
https://github.com/apache/incubator-gluten/pull/5007/files#diff-dc93325490d76d420bdb064320fd3e79da8a05c20eea0298c5638a9cde0e45da
is done we can revert this change?
cc @WangGuangxin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
