taiyang-li commented on code in PR #5311: URL: https://github.com/apache/incubator-gluten/pull/5311#discussion_r1556847102
########## cpp-ch/local-engine/Parser/aggregate_function_parser/CommonAggregateFunctionParser.cpp: ########## @@ -25,17 +25,17 @@ REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Sum, sum, sum) REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Avg, avg, avg) REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Min, min, min) REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Max, max, max) -REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(StdDev, stddev, stddev_samp) Review Comment: How much performance degradation if replace them all to stable implementations? According to https://clickhouse.com/docs/en/sql-reference/aggregate-functions/reference/stddevsamp: use the stddevSampStable function. It works slower but provides a lower computational error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
