taiyang-li commented on code in PR #5311:
URL: https://github.com/apache/incubator-gluten/pull/5311#discussion_r1556863971
##########
cpp-ch/local-engine/Parser/AggregateFunctionParser.cpp:
##########
@@ -174,6 +174,28 @@ const DB::ActionsDAG::Node *
AggregateFunctionParser::convertNodeTypeIfNeeded(
return func_node;
}
+const DB::ActionsDAG::Node * AggregateFunctionParser::convertInfiniteIfNeeded(
+ const CommonFunctionInfo & func_info,
+ const DB::ActionsDAG::Node * func_node,
+ DB::ActionsDAGPtr & actions_dag) const
+{
+ static std::unordered_set<String> infinite_aggs{"varSampStable",
"stddevSampStable", "covarSampStable"};
Review Comment:
It seems tricky. Pls Implement convertInfiniteIfNeeded for `infinite_aggs`
and keep it dummy for other aggregate functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
