zhztheplayer commented on code in PR #5655:
URL: https://github.com/apache/incubator-gluten/pull/5655#discussion_r1596431877
##########
backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala:
##########
@@ -106,15 +112,38 @@ class FallbackSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSparkPl
}
}
- // java.lang.NullPointerException
- ignore("fallback final aggregate of collect_list") {
+ test("fallback collect_list") {
+ withSQLConf(
+ GlutenConfig.EXPRESSION_BLACK_LIST.key -> "collect_list"
Review Comment:
Added a set of cases here
https://github.com/apache/incubator-gluten/pull/5655/files#diff-742ce9027f0d774d324125a130d9993bad09d4ea5eb6d35d791b39bb57138c77R983-R1057
for better coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
