zhztheplayer commented on code in PR #5655:
URL: https://github.com/apache/incubator-gluten/pull/5655#discussion_r1596504202
##########
backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala:
##########
@@ -106,15 +112,44 @@ class FallbackSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSparkPl
}
}
- // java.lang.NullPointerException
- ignore("fallback final aggregate of collect_list") {
+ test("fallback collect_list") {
+ withSQLConf(
+ GlutenConfig.EXPRESSION_BLACK_LIST.key -> "collect_list"
+ ) {
+ CollectRewriteRule.forceEnableAndRun {
+ val df = spark.sql("SELECT c1, collect_list(c2) FROM tmp3 GROUP BY c1")
+ val result = df.collect()
+ assert(result.length == 3)
+ assert(result.map(_.getList[Int](1).size()).sum == 100)
+ val plan = df.queryExecution.executedPlan
+ assert(collect(plan) { case v: HashAggregateExecBaseTransformer => v
}.isEmpty)
+ }
+ }
+ }
+
+ test("fallback collect_set") {
+ withSQLConf(
+ GlutenConfig.EXPRESSION_BLACK_LIST.key -> "collect_set"
+ ) {
+ CollectRewriteRule.forceEnableAndRun {
Review Comment:
I'll remove this API and the two tests. They are not useful for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
