liujiayi771 commented on code in PR #6503:
URL: https://github.com/apache/incubator-gluten/pull/6503#discussion_r1682424242
##########
gluten-core/src/main/java/org/apache/gluten/substrait/rel/LocalFilesNode.java:
##########
@@ -78,6 +80,7 @@ public enum ReadFileFormat {
this.partitionColumns.addAll(partitionColumns);
this.metadataColumns.addAll(metadataColumns);
this.preferredLocations.addAll(preferredLocations);
+ this.fileReadProperties= properties;
Review Comment:
Do we use this variable in `LocalFilesNode`?
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala:
##########
@@ -122,7 +122,8 @@ class CHIteratorApi extends IteratorApi with Logging with
LogLevelUtil {
partition: InputPartition,
partitionSchema: StructType,
fileFormat: ReadFileFormat,
- metadataColumnNames: Seq[String]): SplitInfo = {
+ metadataColumnNames: Seq[String],
+ scan: BasicScanExecTransformer): SplitInfo = {
Review Comment:
It is better to only pass the properties that are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
