kecookier commented on code in PR #6503:
URL: https://github.com/apache/incubator-gluten/pull/6503#discussion_r1682459728
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala:
##########
@@ -122,7 +122,8 @@ class CHIteratorApi extends IteratorApi with Logging with
LogLevelUtil {
partition: InputPartition,
partitionSchema: StructType,
fileFormat: ReadFileFormat,
- metadataColumnNames: Seq[String]): SplitInfo = {
+ metadataColumnNames: Seq[String],
+ scan: BasicScanExecTransformer): SplitInfo = {
Review Comment:
Yes, you are right, but we may also need to pass `scan.getDataSchema` to the
`setFileSchema` of the `LocalFilesNode`, which is to fix
https://github.com/apache/incubator-gluten/issues/5638 in the future. What's
your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
