zhztheplayer commented on code in PR #8454:
URL: https://github.com/apache/incubator-gluten/pull/8454#discussion_r1906195025
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarCachedBatchSerializer.scala:
##########
@@ -17,7 +17,7 @@
package org.apache.spark.sql.execution
import org.apache.gluten.backendsapi.BackendsApiManager
-import org.apache.gluten.columnarbatch.ColumnarBatches
+import org.apache.gluten.columnarbatch.{ColumnarBatches, VeloxColumnarBatches}
Review Comment:
Yes It's normal to call the utility from Velox backend code. However it's
unusall to rely on `isLightBatch` / `isHeavyBatch` to conduct conditional
transitions.
@ArnavBalyan Would you like to help check if we can somehow add explicit
transition nodes (LoadArrowData / OffloadArrowData) into query plan instead of
the PR's change? Thanks!
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarCachedBatchSerializer.scala:
##########
@@ -17,7 +17,7 @@
package org.apache.spark.sql.execution
import org.apache.gluten.backendsapi.BackendsApiManager
-import org.apache.gluten.columnarbatch.ColumnarBatches
+import org.apache.gluten.columnarbatch.{ColumnarBatches, VeloxColumnarBatches}
Review Comment:
Yes it's normal to call the utility from Velox backend code. However it's
unusall to rely on `isLightBatch` / `isHeavyBatch` to conduct conditional
transitions.
@ArnavBalyan Would you like to help check if we can somehow add explicit
transition nodes (LoadArrowData / OffloadArrowData) into query plan instead of
the PR's change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
