zhztheplayer commented on code in PR #8454:
URL: https://github.com/apache/incubator-gluten/pull/8454#discussion_r1906540105
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarCachedBatchSerializer.scala:
##########
@@ -17,7 +17,7 @@
package org.apache.spark.sql.execution
import org.apache.gluten.backendsapi.BackendsApiManager
-import org.apache.gluten.columnarbatch.ColumnarBatches
+import org.apache.gluten.columnarbatch.{ColumnarBatches, VeloxColumnarBatches}
Review Comment:
> However the serializer is a special case since it's not an operator and
does not extend the GlutenPlan
Agreed. The code path is different. Thanks for figuring out on this.
Do you think we can add a UT for the change in this PR? If this can be
considered an individual fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
