taiyang-li commented on code in PR #8518:
URL: https://github.com/apache/incubator-gluten/pull/8518#discussion_r1952055240
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala:
##########
@@ -363,22 +366,21 @@ case class WholeStageTransformer(child: SparkPlan,
materializeInput: Boolean = f
GlutenConfig.get.substraitPlanLogLevel,
s"$nodeName generating the substrait plan took: $t ms."))
val inputRDDs = new ColumnarInputRDDsWrapper(columnarInputRDDs)
- // Check if BatchScan exists.
- val basicScanExecTransformers = findAllScanTransformers()
- if (basicScanExecTransformers.nonEmpty) {
+ val leafTransformers = findAllLeafTransformers()
+ if (leafTransformers.nonEmpty) {
/**
* If containing scan exec transformer this "whole stage" generates a
RDD which itself takes
* care of SCAN there won't be any other RDD for SCAN. As a result,
genFirstStageIterator
* rather than genFinalStageIterator will be invoked
*/
- val allScanPartitions =
basicScanExecTransformers.map(_.getPartitions.toIndexedSeq)
Review Comment:
@PHILO-HE could you please review these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
