taiyang-li commented on code in PR #8518:
URL: https://github.com/apache/incubator-gluten/pull/8518#discussion_r1952061390
##########
cpp-ch/local-engine/Parser/RelParsers/ReadRelParser.cpp:
##########
@@ -53,15 +56,35 @@ ReadRelParser::parse(DB::QueryPlanPtr query_plan, const
substrait::Rel & rel, st
{
if (query_plan)
throw DB::Exception(DB::ErrorCodes::LOGICAL_ERROR, "Source node's
input plan should be null");
+
const auto & read = rel.read();
- if (isReadFromDefault(read))
Review Comment:
@baibaichen could you please review changs in ReadRelParser.* and
SerializedPlanParser.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
