zhztheplayer commented on code in PR #8798:
URL: https://github.com/apache/incubator-gluten/pull/8798#discussion_r1966999632
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/GlutenPlan.scala:
##########
@@ -26,6 +26,7 @@ import org.apache.spark.sql.catalyst.trees.TreeNode
sealed trait ValidationResult {
def ok(): Boolean
def reason(): String
+ def merge(other: ValidationResult): ValidationResult
Review Comment:
I see fallback tags already support appending:
https://github.com/apache/incubator-gluten/blob/453cbebc26f5dfef76669f8abcda578820420352/gluten-core/src/main/scala/org/apache/gluten/extension/columnar/FallbackTag.scala#L37C14-L37C24
Can we do merge either only on tags or only on validation results? Say,
either to make tags mergeable and then convert the merged tag to a big
validation result, or to make tags non-mergeable then convert the tags to
validation results that can be merged afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
