marin-ma commented on code in PR #8798:
URL: https://github.com/apache/incubator-gluten/pull/8798#discussion_r1969846943
##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -1310,6 +1312,12 @@ object GlutenConfig {
.booleanConf
.createWithDefault(false)
+ val VALIDATION_FAIL_FAST =
+ buildConf("spark.gluten.sql.validation.failFast")
+ .internal()
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
Non-fast-failing may impact performance, as there are more validation
process to run. It should be preferred to still keep the fast-failing by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
