jinchengchenghh commented on code in PR #8967:
URL: https://github.com/apache/incubator-gluten/pull/8967#discussion_r1991060827
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala:
##########
@@ -1193,6 +1193,28 @@ class VeloxAggregateFunctionsDefaultSuite extends
VeloxAggregateFunctionsSuite {
}
}
}
+
+ test("aggregate on join keys can set ignoreNullKeys") {
+ val s =
+ """
Review Comment:
The test data does not contains nulls by `createTPCHNotNullTables()`, so it
cannot well test this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
