WangGuangxin commented on code in PR #8967:
URL: https://github.com/apache/incubator-gluten/pull/8967#discussion_r1991531253
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala:
##########
@@ -1193,6 +1193,28 @@ class VeloxAggregateFunctionsDefaultSuite extends
VeloxAggregateFunctionsSuite {
}
}
}
+
+ test("aggregate on join keys can set ignoreNullKeys") {
+ val s =
+ """
+ |select count(1) from
+ | (select l_orderkey, max(l_partkey) from lineitem group by
l_orderkey) a
Review Comment:
it doesn't matter. if the pattern is
```
agg(k1) t
\ /
\ /
join(k1 = k2)
```
then we can safely ignore the null values in k1 when doing aggregation, no
matter whether `join` is offloaded of not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
