WangGuangxin commented on code in PR #9035:
URL: https://github.com/apache/incubator-gluten/pull/9035#discussion_r2010903101
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -914,4 +915,25 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
child: Seq[SparkPlan]): ColumnarRangeBaseExec =
ColumnarRangeExec(start, end, step, numSlices, numElements,
outputAttributes, child)
+ override def genShuffleRead(plan: SparkPlan): SparkPlan = {
+ if (!VeloxConfig.get.veloxResizeBatchesShuffleInput) return plan
Review Comment:
seems there are performance downgrade. I'll investigate later
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -914,4 +915,25 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
child: Seq[SparkPlan]): ColumnarRangeBaseExec =
ColumnarRangeExec(start, end, step, numSlices, numElements,
outputAttributes, child)
+ override def genShuffleRead(plan: SparkPlan): SparkPlan = {
+ if (!VeloxConfig.get.veloxResizeBatchesShuffleInput) return plan
Review Comment:
seems there are performance regression. I'll investigate later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
