WangGuangxin commented on code in PR #9035:
URL: https://github.com/apache/incubator-gluten/pull/9035#discussion_r2041333656
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -306,6 +317,21 @@ object VeloxConfig {
.intConf
.createOptional
+ val COLUMNAR_VELOX_RESIZE_BATCHES_SHUFFLE_INPUT_OUTPUT_MIN_SIZE =
Review Comment:
This is used both for the BatchResizing before shuffle input and after
shuffle output, so that we can reduce some config. Usually there is need to do
too much customized min size config for these two scenario. What do you think?
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -294,6 +297,14 @@ object VeloxConfig {
.booleanConf
.createWithDefault(true)
+ val COLUMNAR_VELOX_RESIZE_BATCHES_SHUFFLE_OUTPUT =
+
buildConf("spark.gluten.sql.columnar.backend.velox.resizeBatches.shuffleOutput")
+ .internal()
+ .doc(s"If true, combine small columnar batches together right after
shuffle read. " +
+ s"The default minimum output batch size is equal to 0.8 *
${COLUMNAR_MAX_BATCH_SIZE.key}")
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
