PHILO-HE commented on code in PR #9088:
URL: https://github.com/apache/incubator-gluten/pull/9088#discussion_r2021450306
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala:
##########
@@ -55,18 +55,24 @@ import scala.collection.mutable.ArrayBuffer
class CHIteratorApi extends IteratorApi with Logging with LogLevelUtil {
- private def getFileSchema(schema: StructType, names: Seq[String]):
StructType = {
- val dataSchema = ArrayBuffer[StructField]()
+ private def getFileSchema(schema: StructType, names: Seq[String]):
java.util.List[SchemaField] = {
Review Comment:
Can we just create a class type that holds multiple field elements? Then,
directly replace StructType with the new class type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
