PHILO-HE commented on code in PR #9088:
URL: https://github.com/apache/incubator-gluten/pull/9088#discussion_r2023062601
##########
gluten-substrait/src/main/java/org/apache/gluten/substrait/expression/WindowFunctionNode.java:
##########
Review Comment:
I am afraid that these code for constructing window node cannot be reused by
Flink. If true, do we need these code changes for removing the dependency on
Spark? I am thinking whether it is reasonable to move it to a submodule also.
##########
gluten-substrait/src/main/java/org/apache/gluten/utils/SparkToJavaConverter.java:
##########
Review Comment:
ditto.
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala:
##########
@@ -17,6 +17,7 @@
package org.apache.gluten.expression
import org.apache.gluten.substrait.expression.{ExpressionBuilder,
ExpressionNode}
+import org.apache.gluten.utils.SparkToJavaConverter
import org.apache.spark.sql.catalyst.expressions.{Expression, Literal}
import org.apache.spark.sql.types.DataType
Review Comment:
@shuai-xu, there are still some spark classes used. Do we need to add a
submodule to hold such code that is close to Substriat but is Spark-specific?
cc @zhztheplayer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
