zhouyuan commented on code in PR #9183: URL: https://github.com/apache/incubator-gluten/pull/9183#discussion_r2022436425
########## docs/get-started/VeloxS3.md: ########## @@ -48,13 +48,20 @@ Note that `spark.hadoop.fs.s3a.iam.role.session.name` is optional. ## Log granularity of AWS C++ SDK in velox You can change log granularity of AWS C++ SDK by setting the `spark.gluten.velox.awsSdkLogLevel` configuration. The Allowed values are: -* OFF -* FATAL -* ERROR -* WARN -* INFO -* DEBUG -* TRACE + "OFF", "FATAL", "ERROR", "WARN", "INFO", "DEBUG", "TRACE". + +## Configuring Whether To Use Proxy From Env for S3 C++ Client Review Comment: i understand this is aligning with velox config, but is this a standard aws-sdk-cpp feature? they seems to disable proxy by intention https://github.com/aws/aws-sdk-cpp/issues/1049 ########## cpp/velox/utils/ConfigExtractor.cc: ########## @@ -72,6 +83,8 @@ std::shared_ptr<facebook::velox::config::ConfigBase> getHiveConfig( {S3Config::Keys::kUseInstanceCredentials, std::make_pair("instance.credentials", "false")}, {S3Config::Keys::kIamRole, std::make_pair("iam.role", std::nullopt)}, {S3Config::Keys::kIamRoleSessionName, std::make_pair("iam.role.session.name", "gluten-session")}, + {S3Config::Keys::kEndpointRegion, std::make_pair("endpoint.region", std::nullopt)}, + {S3Config::Keys::kCredentialsProvider, std::make_pair("aws.credentials.provider", std::nullopt)}, Review Comment: thanks for adding this Cc @marin-ma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
