jinchengchenghh commented on code in PR #9183: URL: https://github.com/apache/incubator-gluten/pull/9183#discussion_r2023145407
########## cpp/velox/utils/ConfigExtractor.cc: ########## @@ -59,6 +59,17 @@ std::shared_ptr<facebook::velox::config::ConfigBase> getHiveConfig( const std::string kVeloxAwsSdkLogLevel = "spark.gluten.velox.awsSdkLogLevel"; const std::string kVeloxAwsSdkLogLevelDefault = "FATAL"; + // Whether to use proxy from env for s3 c++ client Review Comment: All the config in native backend should have an entry in GlutenConfig.scala, and these configs should add to function `getNativeBackendConf` like other S3 config. Otherwise, the config cannot send to native backend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
