PHILO-HE commented on code in PR #9150:
URL: https://github.com/apache/incubator-gluten/pull/9150#discussion_r2026282057
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -142,13 +142,27 @@ class VeloxListenerApi extends ListenerApi with Logging {
}
SparkDirectoryUtil.init(conf)
- UDFResolver.resolveUdfConf(conf, isDriver = false)
initialize(conf, isDriver = false)
}
override def onExecutorShutdown(): Unit = shutdown()
private def initialize(conf: SparkConf, isDriver: Boolean): Unit = {
+ // Sets this configuration only once, since not undoable.
+ // DebugInstance should be created first.
+ if (conf.getBoolean(GlutenConfig.DEBUG_KEEP_JNI_WORKSPACE.key,
defaultValue = false)) {
+ val debugDir = conf.get(GlutenConfig.DEBUG_KEEP_JNI_WORKSPACE_DIR.key)
+ JniWorkspace.enableDebug(debugDir)
+ }
+ JniWorkspace.initializeDefault(
Review Comment:
If debug is enabled, no need to `initializeDefault`. Should we add an `else`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
