zhztheplayer commented on code in PR #9150:
URL: https://github.com/apache/incubator-gluten/pull/9150#discussion_r2026727693
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -215,6 +224,7 @@ class VeloxListenerApi extends ListenerApi with Logging {
private def shutdown(): Unit = {
// TODO shutdown implementation in velox to release resources
+ JniLibLoader.forceUnloadAll
Review Comment:
The usage of `unload` is also questionable. JVM doesn't have a certain
timing for such operation because it's related to GC / JVM implementations.
We'd avoid unloading the libs unless really necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
