dcoliversun commented on code in PR #9183:
URL: https://github.com/apache/incubator-gluten/pull/9183#discussion_r2026341392
##########
cpp/velox/utils/ConfigExtractor.cc:
##########
@@ -72,6 +83,8 @@ std::shared_ptr<facebook::velox::config::ConfigBase>
getHiveConfig(
{S3Config::Keys::kUseInstanceCredentials,
std::make_pair("instance.credentials", "false")},
{S3Config::Keys::kIamRole, std::make_pair("iam.role", std::nullopt)},
{S3Config::Keys::kIamRoleSessionName,
std::make_pair("iam.role.session.name", "gluten-session")},
+ {S3Config::Keys::kEndpointRegion, std::make_pair("endpoint.region",
std::nullopt)},
+ {S3Config::Keys::kCredentialsProvider,
std::make_pair("aws.credentials.provider", std::nullopt)},
Review Comment:
@marin-ma Your concern is valid. Although the `SimpleAWSCredentialsProvider`
is not required when declaring ak/sk, this piece of code might still disrupt
some stable workflows. One idea I have is to use a different configuration name
to distinguish it, or not set credentials provider configuration when declaring
ak/sk.
If we choose second path, I guess it's better to add some codes in velox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
