shuai-xu commented on code in PR #9446:
URL: https://github.com/apache/incubator-gluten/pull/9446#discussion_r2074667293
##########
gluten-flink/runtime/src/main/java/org/apache/flink/client/StreamGraphTranslator.java:
##########
@@ -89,61 +90,76 @@ private JobGraph mergeGlutenOperators(JobGraph jobGraph) {
for (JobVertex vertex : jobGraph.getVertices()) {
StreamConfig streamConfig = new
StreamConfig(vertex.getConfiguration());
buildGlutenChains(streamConfig);
+ LOG.debug("Vertex {} is {}.", vertex.getName(), streamConfig);
}
return jobGraph;
}
private void buildGlutenChains(
- StreamConfig taskConfig) {
- // TODO: only support head operator now.
- if (isGlutenOperator(taskConfig)) {
- while (true) {
- List<StreamEdge> outEdges =
taskConfig.getChainedOutputs(userClassloader);
- if (outEdges.size() != 1) {
- // only support operators have one output.
- break;
+ StreamConfig vertexConfig) {
+ Map<Integer, StreamConfig> serializedTasks =
+ vertexConfig.getTransitiveChainedTaskConfigs(userClassloader);
+ Map<Integer, StreamConfig> chainedTasks = new
HashMap<>(serializedTasks.size());
+ serializedTasks.forEach(
+ (id, config) ->
+ chainedTasks.put(id, new
StreamConfig(config.getConfiguration()))
+ );
+ StreamConfig taskConfig = vertexConfig;
Review Comment:
Yes, vertexConfig is deserialized from JobVertex, some fields are not
initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
