zhztheplayer commented on code in PR #9446:
URL: https://github.com/apache/incubator-gluten/pull/9446#discussion_r2074958362
##########
gluten-flink/runtime/src/main/java/org/apache/gluten/table/runtime/operators/GlutenSingleInputOperator.java:
##########
@@ -75,7 +83,8 @@ public GlutenCalOperator(String plan, String id, String
inputType, String output
public void open() throws Exception {
super.open();
outElement = new StreamRecord(null);
- session =
Velox4j.newSession(MemoryManager.create(AllocationListener.NOOP));
+ memoryManager = MemoryManager.create(AllocationListener.NOOP);
+ session = Velox4j.newSession(memoryManager);
inputQueue = new LinkedBlockingQueue<>();
Review Comment:
> Can we update it in a seperated pull request?
Yes that's fine to me.
##########
gluten-flink/runtime/src/main/java/org/apache/gluten/table/runtime/operators/GlutenSingleInputOperator.java:
##########
@@ -75,7 +83,8 @@ public GlutenCalOperator(String plan, String id, String
inputType, String output
public void open() throws Exception {
super.open();
outElement = new StreamRecord(null);
- session =
Velox4j.newSession(MemoryManager.create(AllocationListener.NOOP));
+ memoryManager = MemoryManager.create(AllocationListener.NOOP);
+ session = Velox4j.newSession(memoryManager);
inputQueue = new LinkedBlockingQueue<>();
Review Comment:
> Can we update it in a seperated pull request?
Yes that's fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
