shuai-xu commented on code in PR #9576:
URL: https://github.com/apache/incubator-gluten/pull/9576#discussion_r2081357581
##########
gluten-flink/pom.xml:
##########
@@ -38,5 +38,79 @@
<properties>
<flink.version>1.19.2</flink.version>
<velox4j.version>0.1.0-SNAPSHOT</velox4j.version>
+
+ <spotless.version>2.27.2</spotless.version>
+ <spotless.scalafmt.version>3.8.3</spotless.scalafmt.version>
+ <spotless.delimiter>package</spotless.delimiter>
+ <spotless.license.header>
+/*
Review Comment:
gluten already have header check, does it need to add it here again?
##########
gluten-flink/planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecCalc.java:
##########
@@ -14,40 +14,38 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.flink.table.planner.plan.nodes.exec.stream;
+import org.apache.gluten.rexnode.RexNodeConverter;
import org.apache.gluten.rexnode.Utils;
import org.apache.gluten.table.runtime.operators.GlutenSingleInputOperator;
import org.apache.gluten.util.LogicalTypeConverter;
-import org.apache.gluten.rexnode.RexNodeConverter;
+import org.apache.gluten.util.PlanNodeIdGenerator;
import io.github.zhztheplayer.velox4j.expression.TypedExpr;
import io.github.zhztheplayer.velox4j.plan.FilterNode;
import io.github.zhztheplayer.velox4j.plan.PlanNode;
import io.github.zhztheplayer.velox4j.plan.ProjectNode;
-
import org.apache.calcite.rex.RexNode;
import org.apache.flink.FlinkVersion;
import org.apache.flink.api.dag.Transformation;
import org.apache.flink.configuration.ReadableConfig;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
Review Comment:
Flink seems to put shaded package at last, better to follow its style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
