shuai-xu commented on code in PR #9576: URL: https://github.com/apache/incubator-gluten/pull/9576#discussion_r2083950906
########## gluten-flink/.scalafmt.conf: ########## @@ -0,0 +1,71 @@ +runner.dialect = scala212 + +# Version is required to make sure IntelliJ picks the right version +version = 3.8.3 +preset = default + +# Max column +maxColumn = 100 + +# This parameter simply says the .stripMargin method was not redefined by the user to assign +# special meaning to indentation preceding the | character. Hence, that indentation can be modified. +assumeStandardLibraryStripMargin = true +align.stripMargin = true + +# Align settings +align.preset = none +align.closeParenSite = false +align.openParenCallSite = false +danglingParentheses.defnSite = false +danglingParentheses.callSite = false +danglingParentheses.ctrlSite = true +danglingParentheses.tupleSite = false +align.openParenCallSite = false +align.openParenDefnSite = false +align.openParenTupleSite = false + +# Newlines +newlines.alwaysBeforeElseAfterCurlyIf = false +newlines.beforeCurlyLambdaParams = multiline # Newline before lambda params +newlines.afterCurlyLambdaParams = squash # No newline after lambda params +newlines.inInterpolation = "avoid" +newlines.avoidInResultType = true +optIn.annotationNewlines = true + +# Scaladoc +docstrings.style = Asterisk # Javadoc style +docstrings.removeEmpty = true +docstrings.oneline = fold +docstrings.forceBlankLineBefore = true + +# Indentation +indent.extendSite = 2 # This makes sure extend is not indented as the ctor parameters + +# Rewrites +rewrite.rules = [AvoidInfix, Imports, RedundantBraces, SortModifiers] + +# Imports +rewrite.imports.sort = scalastyle +rewrite.imports.groups = [ + ["org.apache.gluten\\..*"], Review Comment: There should be no spark related in Flink ########## gluten-flink/planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecCalc.java: ########## @@ -14,40 +14,38 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.flink.table.planner.plan.nodes.exec.stream; +import org.apache.gluten.rexnode.RexNodeConverter; import org.apache.gluten.rexnode.Utils; import org.apache.gluten.table.runtime.operators.GlutenSingleInputOperator; import org.apache.gluten.util.LogicalTypeConverter; -import org.apache.gluten.rexnode.RexNodeConverter; +import org.apache.gluten.util.PlanNodeIdGenerator; import io.github.zhztheplayer.velox4j.expression.TypedExpr; import io.github.zhztheplayer.velox4j.plan.FilterNode; import io.github.zhztheplayer.velox4j.plan.PlanNode; import io.github.zhztheplayer.velox4j.plan.ProjectNode; - import org.apache.calcite.rex.RexNode; import org.apache.flink.FlinkVersion; import org.apache.flink.api.dag.Transformation; import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator; Review Comment: I think we should not change flink's import order -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
