JkSelf commented on code in PR #9694:
URL: https://github.com/apache/incubator-gluten/pull/9694#discussion_r2096937398
##########
backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala:
##########
@@ -170,6 +170,7 @@ object CHExpressionUtil {
final val CH_AGGREGATE_FUNC_BLACKLIST: Map[String, FunctionValidator] = Map(
MAX_BY -> DefaultValidator(),
MIN_BY -> DefaultValidator()
+ MODE -> DefaultValidator()
Review Comment:
No need to modify the `clickhouse `code when only implement the `mode `
function in Velox backend.
##########
cpp-ch/local-engine/Parser/aggregate_function_parser/CommonAggregateFunctionParser.cpp:
##########
@@ -25,6 +25,7 @@ REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Sum, sum, sum)
REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Avg, avg, avg)
REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Min, min, min)
REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Max, max, max)
+REGISTER_COMMON_AGGREGATE_FUNCTION_PARSER(Mode, mode, mode)
Review Comment:
Remove this change in clickhouse module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
