PHILO-HE commented on code in PR #9694:
URL: https://github.com/apache/incubator-gluten/pull/9694#discussion_r2096969927
##########
backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala:
##########
@@ -170,6 +170,7 @@ object CHExpressionUtil {
final val CH_AGGREGATE_FUNC_BLACKLIST: Map[String, FunctionValidator] = Map(
MAX_BY -> DefaultValidator(),
MIN_BY -> DefaultValidator()
+ MODE -> DefaultValidator()
Review Comment:
@JkSelf, sometimes we need this to allow fallback for CH backend. This is
because our added function in shared module may make Gluten try to offload this
new function to Clickhouse backend. I am not quite sure. @okhleif-IL, we only
need this change when some relevant error is reported for CH backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
