PHILO-HE commented on code in PR #10158:
URL:
https://github.com/apache/incubator-gluten/pull/10158#discussion_r2199411441
##########
dev/build_arrow.sh:
##########
@@ -35,9 +35,15 @@ function prepare_arrow_build() {
}
function build_arrow_cpp() {
- pushd $ARROW_PREFIX/cpp
-
- cmake_install \
+ pushd $ARROW_PREFIX/cpp
+ ARROW_WITH_ZLIB=ON
+ if [[ "$(uname)" == "Darwin" ]]; then
+ clang_major_version=$(echo | clang -dM -E - | grep __clang_major__ | awk
'{print $3}')
+ if [ "${clang_major_version}" -ge 17 ]; then
+ ARROW_WITH_ZLIB=OFF
Review Comment:
I meant its impact when clang 17 is used.
I note there are some fixes in Velox community for clang 17 build, e.g.,
https://github.com/facebookincubator/velox/pull/13598. So I assume building
velox/arrow can pass with clang 17 at that side. Curious if there is any other
fix in Velox community instead of turning off this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
