zml1206 commented on code in PR #10158:
URL:
https://github.com/apache/incubator-gluten/pull/10158#discussion_r2199782857
##########
dev/build_arrow.sh:
##########
@@ -35,9 +35,15 @@ function prepare_arrow_build() {
}
function build_arrow_cpp() {
- pushd $ARROW_PREFIX/cpp
-
- cmake_install \
+ pushd $ARROW_PREFIX/cpp
+ ARROW_WITH_ZLIB=ON
+ if [[ "$(uname)" == "Darwin" ]]; then
+ clang_major_version=$(echo | clang -dM -E - | grep __clang_major__ | awk
'{print $3}')
+ if [ "${clang_major_version}" -ge 17 ]; then
+ ARROW_WITH_ZLIB=OFF
Review Comment:
There is no problem compiling arrow/velox using system's zlib, but compiling
gluten cpp gives an error, it seems that the version is incompatible.
```
Undefined symbols for architecture arm64:
"_deflate", referenced from:
arrow::util::internal::(anonymous namespace)::GZipCodec::Compress(long
long, unsigned char const*, long long, unsigned char*) in
libarrow.a[120](compression_zlib.cc.o)
arrow::util::internal::(anonymous
namespace)::GZipCompressor::Compress(long long, unsigned char const*, long
long, unsigned char*) in libarrow.a[120](compression_zlib.cc.o)
arrow::util::internal::(anonymous
namespace)::GZipCompressor::Flush(long long, unsigned char*) in
libarrow.a[120](compression_zlib.cc.o)
```
I ran some UT locally on my Mac and there were no problems. I guess as long
as don't use zlib compression, it shouldn't have any effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
