kerwin-zk commented on code in PR #10235:
URL:
https://github.com/apache/incubator-gluten/pull/10235#discussion_r2219654835
##########
cpp/velox/shuffle/VeloxRssSortShuffleWriter.h:
##########
@@ -89,6 +95,10 @@ class VeloxRssSortShuffleWriter final : public
VeloxShuffleWriter {
void stat() const;
+ void calculateBatchesSize(facebook::velox::RowVectorPtr& vector);
Review Comment:
Here the suggestion is to use ```const```
##########
cpp/velox/shuffle/VeloxRssSortShuffleWriter.h:
##########
@@ -89,6 +95,10 @@ class VeloxRssSortShuffleWriter final : public
VeloxShuffleWriter {
void stat() const;
+ void calculateBatchesSize(facebook::velox::RowVectorPtr& vector);
+
+ void deduplicateStrBuffer(facebook::velox::VectorPtr& vector);
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
