kerwin-zk commented on code in PR #10235:
URL:
https://github.com/apache/incubator-gluten/pull/10235#discussion_r2219668764
##########
cpp/velox/shuffle/VeloxRssSortShuffleWriter.h:
##########
@@ -108,6 +118,10 @@ class VeloxRssSortShuffleWriter final : public
VeloxShuffleWriter {
uint32_t currentInputColumnBytes_ = 0;
RssSortState sortState_{kSortInit};
+
+ // The existing string buffers in the current batches.
+ std::unordered_set<facebook::velox::Buffer*> stringBuffers_;
Review Comment:
It would be better to use ```folly::F14FastSet<const Buffer*>```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
