zjuwangg commented on code in PR #10659:
URL:
https://github.com/apache/incubator-gluten/pull/10659#discussion_r2338366483
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -538,6 +538,7 @@ object VeloxConfig {
val VELOX_BROADCAST_BUILD_RELATION_USE_OFFHEAP =
buildConf("spark.gluten.velox.offHeapBroadcastBuildRelation.enabled")
.internal()
+ .experimental()
Review Comment:
@PHILO-HE I have also thought add check here during development. But
`experimental` and `internal` behavior should be orthogonality. And if we add
check, we must first call `internal` and then call `experimental` which also is
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
